Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pose_instability_detector): fix a crash bug in pose_instability_detector #1370

Merged

Conversation

SakodaShintaro
Copy link

@SakodaShintaro SakodaShintaro commented Jul 2, 2024

Description

Cherry-pick of the following PR

This seems to occur when performing initial position estimation twice, as the EKF is lost during the second iteration.

Error

1719899212.4359140 [ERROR] [pose_instability_detector_node-77]: process has died [pid 97654, exit code -6, cmd '/home/autoware/pilot-auto.xx1/install/pose_instability_detector/lib/pose_instability_detector/pose_instability_detector_node --ros-args -r __node:=pose_instability_detector -r __ns:=/localization/pose_twist_fusion_filter -p use_sim_time:=False -p wheel_radius:=0.31 -p wheel_width:=0.18 -p wheel_base:=2.75 -p wheel_tread:=1.485 -p front_overhang:=0.8 -p rear_overhang:=0.85 -p left_overhang:=0.105 -p right_overhang:=0.105 -p vehicle_height:=2.5 -p max_steer_angle:=0.55 --params-file /home/autoware/pilot-auto.xx1/install/pose_instability_detector/share/pose_instability_detector/config/pose_instability_detector.param.yaml -r ~/input/odometry:=/localization/kinematic_state -r ~/input/twist:=/localization/twist_estimator/twist_with_covariance'].
1719899211.9946663 [pose_instability_detector_node-77] *** Aborted at 1719899211 (unix time) try "date -d @1719899211" if you are using GNU date ***
1719899211.9958658 [pose_instability_detector_node-77] PC: @ 0x0 (unknown)
1719899211.9960396 [pose_instability_detector_node-77] @ 0x7f944d9b74d6 google::(anonymous namespace)::FailureSignalHandler()
1719899211.9972198 [pose_instability_detector_node-77] @ 0x7f944d24d520 (unknown)
1719899211.9973106 [pose_instability_detector_node-77] @ 0x7f944d2a19fc pthread_kill
1719899211.9982655 [pose_instability_detector_node-77] @ 0x7f944d24d476 raise
1719899211.9983547 [pose_instability_detector_node-77] @ 0x7f944d2337f3 abort
1719899211.9993689 [pose_instability_detector_node-77] @ 0x7f944d4f6b9e (unknown)
1719899211.9994493 [pose_instability_detector_node-77] @ 0x7f944d50220c (unknown)
1719899212.0003834 [pose_instability_detector_node-77] @ 0x7f944d502277 std::terminate()
1719899212.0016036 [pose_instability_detector_node-77] @ 0x7f944d5024d8 __cxa_throw
1719899212.0030823 [pose_instability_detector_node-77] @ 0x7f944d81612a _ZN6rclcpp4TimeC2ERKN18builtin_interfaces3msg5Time_ISaIvEEE16rcl_clock_type_e.cold
1719899212.0042346 [pose_instability_detector_node-77] @ 0x7f944be31d9b PoseInstabilityDetector::clip_out_necessary_twist()
1719899212.0043607 [pose_instability_detector_node-77] @ 0x7f944be3292d PoseInstabilityDetector::dead_reckon()
1719899212.0044293 [pose_instability_detector_node-77] @ 0x7f944be33e51 PoseInstabilityDetector::callback_timer()
1719899212.0045168 [pose_instability_detector_node-77] @ 0x7f944be37565 rclcpp::GenericTimer<>::execute_callback()
1719899212.0056338 [pose_instability_detector_node-77] @ 0x7f944d834ffe rclcpp::Executor::execute_any_executable()
1719899212.0068991 [pose_instability_detector_node-77] @ 0x7f944d83bc90 rclcpp::executors::SingleThreadedExecutor::spin()
1719899212.0070331 [pose_instability_detector_node-77] @ 0x55c4b9c4d486 main
1719899212.0081487 [pose_instability_detector_node-77] @ 0x7f944d234d90 (unknown)
1719899212.0092106 [pose_instability_detector_node-77] @ 0x7f944d234e40 __libc_start_main
1719899212.0093455 [pose_instability_detector_node-77] @ 0x55c4b9c4de35 _start

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…7681)

* Added an error test case

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed to avoid out-of-size access

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed the test case

Signed-off-by: Shintaro Sakoda <[email protected]>

* Fixed test

Signed-off-by: Shintaro Sakoda <[email protected]>

---------

Signed-off-by: Shintaro Sakoda <[email protected]>
Copy link

sonarqubecloud bot commented Jul 2, 2024

@SakodaShintaro SakodaShintaro self-assigned this Jul 2, 2024
@SakodaShintaro SakodaShintaro marked this pull request as ready for review July 2, 2024 07:55
@SakodaShintaro SakodaShintaro merged commit 6da3fea into beta/v0.29.0 Jul 2, 2024
25 of 26 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/crash_bug_in_pose_instability_detector branch July 2, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants